Fix Flutter 3.7 incompatibilities #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mix TextInputClient into CustomTextEditState instead of implementing all of it to avoid breaking whenever a new TextInputClient member is introduced. Fixes: TerminalStudio#150
jpnurmi
commented
Jan 26, 2023
MenuItem was renamed to PlatformMenuItem
jpnurmi
force-pushed
the
text-input-client
branch
from
5edf599
to
20f85d2
Compare
|
For reference, the two new |
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
=======================================
Coverage 64.05% 64.05%
=======================================
Files 52 52
Lines 3158 3158
=======================================
Hits 2023 2023
Misses 1135 1135
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Thanks so much! |
jpnurmi
added a commit
to jpnurmi/workshops
that referenced
this pull request
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TextInputClientintoCustomTextEditStateinstead of implementing all of it to avoid breaking whenever a newTextInputClientmember is introduced.MenuItemwas renamed toPlatformMenuItem. Drop the explicit type in the example to support both versions.Fixes: #150