feat: Add Flush(bool) to FileSystemStream. (#985)

`FileSystemStream` was missing the implementation of `FileStream.Flush(bool)` which allows the caller to specify whether `Flush` should ensure all buffers are written to disk.
TestableIO · May 12, 2023 · ccdc24d · ccdc24d
1 parent 2777be0
commit ccdc24d
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 0 deletions.
diff --git a/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileStream.cs b/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileStream.cs
@@ -223,6 +223,10 @@ public override void Flush()
             InternalFlush();
         }
 
+        /// <inheritdoc />
+        public override void Flush(bool flushToDisk)
+            => InternalFlush();
+
         /// <inheritdoc />
         public override Task FlushAsync(CancellationToken cancellationToken)
         {

diff --git a/src/TestableIO.System.IO.Abstractions.Wrappers/FileStreamWrapper.cs b/src/TestableIO.System.IO.Abstractions.Wrappers/FileStreamWrapper.cs
@@ -41,5 +41,9 @@ public void SetAccessControl(object value)
                 throw new ArgumentException("value must be of type `FileSecurity`");
             }
         }
+
+        /// <inheritdoc />
+        public override void Flush(bool flushToDisk)
+            => fileStream.Flush(flushToDisk);
     }
 }
diff --git a/src/TestableIO.System.IO.Abstractions/FileSystemStream.cs b/src/TestableIO.System.IO.Abstractions/FileSystemStream.cs
@@ -128,6 +128,10 @@ public override void EndWrite(IAsyncResult asyncResult)
         public override void Flush()
             => _stream.Flush();
 
+        /// <inheritDoc cref="FileStream.Flush(bool)" />
+        public virtual void Flush(bool flushToDisk)
+            => _stream.Flush();
+
         /// <inheritdoc cref="Stream.FlushAsync(CancellationToken)" />
         public override Task FlushAsync(CancellationToken cancellationToken)
             => _stream.FlushAsync(cancellationToken);

diff --git a/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileStreamTests.cs b/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileStreamTests.cs
@@ -206,5 +206,25 @@ public void MockFileStream_Flush_ShouldNotChangePosition()
                 Assert.AreEqual(200, stream.Position);
             }
         }
+
+        [Test]
+        public void MockFileStream_FlushBool_ShouldNotChangePosition([Values] bool flushToDisk)
+        {
+            // Arrange
+            var fileSystem = new MockFileSystem();
+            var path = XFS.Path("C:\\test");
+            fileSystem.AddFile(path, new MockFileData(new byte[0]));
+
+            using (var stream = fileSystem.FileInfo.New(path).OpenWrite())
+            {
+                // Act
+                stream.Write(new byte[400], 0, 400);
+                stream.Seek(200, SeekOrigin.Begin);
+                stream.Flush(flushToDisk);
+
+                // Assert
+                Assert.AreEqual(200, stream.Position);
+            }
+        }
     }
 }