Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of the new builder #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

vicary
Copy link

@vicary vicary commented Oct 27, 2016

Because ng-model=“$$value$$” doesn’t work on arrays.

Because `ng-model=“$$value$$”` doesn’t work on arrays.
@scottux
Copy link

scottux commented Feb 7, 2018

I have done the same work and also upgraded dependencies, and managed to get the tests working https://github.com/scottux/angular-schema-form-datepicker

This was referenced Feb 7, 2018
@vicary
Copy link
Author

vicary commented Feb 14, 2018

@scottux I don't really have the time to keep-up with core changes in the past year. If you don't mind picking up I can address a few more changes in order to merge with the current development branch in core.

Taking references from https://github.com/json-schema-form/angular-schema-form-bootstrap/blob/develop/src/bootstrap/default.html, they

  1. added "::" to most of the one-time bindings, and
  2. replaced form.key.slice(0, -1) with fieldId(true, false).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants