Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<html> tag is in wrong spot in template used by export_html() #3021

Closed
1j01 opened this issue Jul 1, 2023 · 6 comments
Closed

<html> tag is in wrong spot in template used by export_html() #3021

1j01 opened this issue Jul 1, 2023 · 6 comments
Assignees
@davep
Labels
bug Something isn't working

Comments

@1j01
Copy link

1j01 commented Jul 1, 2023

The CONSOLE_HTML_FORMAT template has <html> after <head>.
<html> should surround <head> to be valid.
@github-actions
Copy link

github-actions bot commented Jul 1, 2023

We found the following entry in the FAQ which you may find helpful:

Feel free to close this issue if you found an answer in the FAQ. Otherwise, please give us a little time to review.

This is an automated reply, generated by FAQtory

@davep
Copy link
Contributor

davep commented Jul 1, 2023

Did you perhaps intend this to be a Rich issue? export_html and CONSOLE_HTML_FORMAT are part of Rich.

@willmcgugan willmcgugan transferred this issue from Textualize/textual Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Thank you for your issue. Give us a little time to review it.

PS. You might want to check the FAQ if you haven't done so already.

This is an automated reply, generated by FAQtory

@davep davep self-assigned this Jul 20, 2023
@davep davep added the bug Something isn't working label Jul 20, 2023
davep added a commit to davep/rich that referenced this issue Jul 20, 2023
@davep
Move the <html> tag to before the <head> in the export template
3089e9f 
See Textualize#3021
@davep davep mentioned this issue Jul 20, 2023
Merged
@rodrigogiraoserrao
Copy link
Contributor

@davep did you forget to close this after the PR above was merged?

@davep
Copy link
Contributor

davep commented Aug 17, 2023

I didn't merge the PR; I wasn't even aware it had been merged.

@github-actions
Copy link

I hope we solved your problem.

If you like using Rich, you might also enjoy Textual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davep davep

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@davep @willmcgugan @1j01 @rodrigogiraoserrao