Show elapsed time when finished in rich.progress.track()

[jankatins]

Before it was showing

Inserting nodes... ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00

now it will show:

Inserting nodes... ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:12:03

-> Now one can see the elapsed time without adding another way to measure that time...

Type of changes

• Bug fix
• New feature
• Documentation / docstrings
• Tests
• Other

Checklist

• I've run the latest black with default args on new code.
• I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
• I've adjusted the test for new code.
• I accept that @willmcgugan may be pedantic in the code review.

Description

Just added the appropriate parameter: TimeRemainingColumn(elapsed_when_finished=True), to the created columns.

[codecov-commenter]

Codecov Report

Patch and project coverage have no change.

Comparison is base (1876380) 98.38% compared to head (f50385d) 98.38%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2659   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files          74       74           
  Lines        7930     7930           
=======================================
  Hits         7802     7802           
  Misses        128      128           

Flag	Coverage Δ
unittests	98.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
rich/cells.py	100.00% <ø> (ø)
rich/progress.py	92.92% <ø> (ø)
rich/segment.py	98.72% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[SertugF]

Normally it shows, estimated time to complete the progress. Making it show another kind of value(time spent for progress) after completion can be confusing for majority of users. That is the main reason its(elapsed_when_finished) default value is set to false. I find making it true is not logical.

[jankatins]

The problem is that the 100% 0:00:00 final output is useless -> it's done, but how long did it take?. The best would be to change it to 100% (took xx:xx:xx). But that would mean a (slightly) bigger change.

[willmcgugan]

Does seem like a better default.