Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auto detection of terminal size on Windows #3413

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Fix auto detection of terminal size on Windows #3413

merged 2 commits into from
Sep 30, 2024

Conversation

lewis-yeung
Copy link
Contributor

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Fix #3412 and supersede #2916.

@lewis-yeung
Copy link
Contributor Author

@willmcgugan Any reviews?

@willmcgugan willmcgugan merged commit 68ead31 into Textualize:master Sep 30, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Incorrect auto detection of terminal size on Windows
2 participants
@lewis-yeung @willmcgugan