Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle dataclasses with Python 3.13 default repr #3455

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

jjhelmus
Copy link
Contributor

@jjhelmus jjhelmus commented Aug 16, 2024

fixes #3368

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

The reprlib module is used for the default __repr__ method in dataclasses starting in Python 3.13.

Allow this module to also be an indication that a dataclass has the default repr.

closes #3368

The reprlib module is used for the default __repr__ method in
dataclasses starting in Python 3.13.

Allow this module to also be an indication that a dataclass has the
default __repr__.

closes Textualize#3368
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.25%. Comparing base (e96ae13) to head (d6abebd).
Report is 5 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3455   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files          74       74           
  Lines        8071     8072    +1     
=======================================
+ Hits         7930     7931    +1     
  Misses        141      141           
Flag Coverage Δ
unittests 98.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willmcgugan
Copy link
Collaborator

Thanks

@willmcgugan willmcgugan merged commit b1397be into Textualize:master Aug 26, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Test failures with Python 3.13.0b1: test_pretty.py and dataclass repr
4 participants