Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should Button variants be runtime validated? #1189

Closed
davep opened this issue Nov 16, 2022 · 1 comment · Fixed by #1195
Closed

Should Button variants be runtime validated? #1189

davep opened this issue Nov 16, 2022 · 1 comment · Fixed by #1195
Labels
question Further information is requested

Comments

@davep
Copy link
Contributor

davep commented Nov 16, 2022

Related to #1188, it seems that Button has a method for validating variants but the code is never used. As seen in #1188 it's possible for someone -- especially if they're not making use of type checking -- to accidentally set a variant that may have an unintended consequence (see the disabled example in the other issue).

Should validate_variant be put to use and an exception be thrown if an unsupported variant is set by the caller?
@davep davep added the question Further information is requested label Nov 16, 2022
@davep davep mentioned this issue Nov 16, 2022
Closed
davep added a commit to davep/textual that referenced this issue Nov 16, 2022
@davep
Check button variant for validity during button construction
e3899c0 
See Textualize#1189
@davep davep mentioned this issue Nov 16, 2022
Merged
@davep davep linked a pull request Nov 16, 2022 that will close this issue
Check button variant for validity during button construction #1195
Merged
@github-actions
Copy link

Did we solve your problem?

Glad we could help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check button variant for validity during button construction davep/textual
1 participant
@davep