Widgets styled with a :hover can sometimes end up with their styles sticking
#1372
Comments
|
After a wee bit more playing, it looks like the issue mainly crops up if the mouse cursor passes out of the terminal window pretty quickly (suggesting that the removal of |
This is the fix for #1372 because the styles that were sticking had nothing to do with `:hover` per se. The issue was in the fact that we were trying to start a second animation (back to the default background color) while the first animation hadn't started yet, so we would skip the creation of the new animation but the old one would still run to completion. This issue also affects animations that start with a delay. If we set an animation A -> B with a delay of 10s and 1s later we set an animation B -> A, then the animation A -> B will run after 9s but the animation B -> A will not run because it was not created in the first place.
|
The real issue was in the fact that we were trying to start a second animation (back to the default background color) while the first animation hasn't started yet, so we skip the creation of the new animation but the old one still runs to completion. This issue also affects animations that start with a delay. If we set an animation A -> B with a delay of 10s and 1s later we set an animation B -> A, then the animation A -> B will run after 9s but the animation B -> A will not run because it was not created in the first place. |
|
Don't forget to star the repository! Follow @textualizeio for Textual updates. |
It's not 100% clear to me yet exactly what happens, but this can be seen with 5x5 from our examples, where a
:hoverstyle can get stuck after the mouse has left the widget. See here for example:In the image 3 cells have the hover style (the background slightly lighter than the background for the other "off" cells). One of them, at the time of the screenshot, had the mouse over it, the other 2 didn't.
This seems to happen if you're a bit quick with mouse movements.
Needs some investigation and a proper route to reproduction found.
The text was updated successfully, but these errors were encountered: