-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a base disabled
property to the Textual widget hierarchy
#1748
Labels
Comments
Note to self: once done this will also resolve #1679. |
davep
added a commit
to davep/textual
that referenced
this issue
Feb 13, 2023
This seems to be a hangover from the early days of the development of `Input`, and the styles do nothing as there's nothing else in the `Input` code that makes use of the class that's involved. Removed in anticipation of Textualize#1748 taking care of this.
davep
added a commit
to davep/textual-sandbox
that referenced
this issue
Feb 13, 2023
To help with working on Textualize/textual#1748
davep
added a commit
to davep/textual
that referenced
this issue
Feb 13, 2023
This doesn't go close to what Textualize#1748 is intending to do, but moves `disabled` to where I want it and keeps `Button` working as before.
Don't forget to star the repository! Follow @textualizeio for Textual updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In most widget frameworks that have come before, it's been very common to have a
disabled
property for all types of widgets, especially those that can receive focus and which the user interacts with; it's also not uncommon for a container widget to have the same and disabling it will result in all children been disabled.Currently Textual only has
disabled
onButton
. There are component classes of a similar name inInput
but it appears no code has even been added to make use of them and anInput
can't currently be disabled.This issue proposes that
disabled
be added as a core property of all Textual widgets, even those that can't directly receive focus. Reasoning being::disabled
pseudo class in CSS.This should ideally be done before #1725.
The text was updated successfully, but these errors were encountered: