Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Both Container and ScrollableContainer can scroll #2361

Closed
willmcgugan opened this issue Apr 22, 2023 · 2 comments · Fixed by #2365
Closed

Both Container and ScrollableContainer can scroll #2361

willmcgugan opened this issue Apr 22, 2023 · 2 comments · Fixed by #2365
Assignees
@davep
Labels
enhancement New feature or request Task

Comments

@willmcgugan
Copy link
Collaborator

Container has auto scrollbars. Unless I'm missing something, I don't think it should scroll by default, as we have ScrollableContainer.
@davep davep added enhancement New feature or request Task labels Apr 24, 2023
@davep davep self-assigned this Apr 24, 2023
@davep
Copy link
Contributor

davep commented Apr 24, 2023

Assuming the intention here is to have Container be overflow: hidden hidden; from now on, this should ideally be marked as a breaking change in the CHANGELOG (it breaks some of our existing tests).

davep added a commit to davep/textual that referenced this issue Apr 24, 2023
@davep
Remove default scrollbars from Container
38e6369 
As per Textualize#2361 this removes default scrollbars on Container (and so adds them
on ScrollableContainer).
davep added a commit to davep/textual that referenced this issue Apr 24, 2023
@davep
By default hide the vertical scrollbar on HorizontalScroll
d06a4e5 
In connection with Textualize#2361.
davep added a commit to davep/textual that referenced this issue Apr 24, 2023
@davep
By default hide the horizontal scrollbar on VerticalScroll
a91b2c6 
In connection with Textualize#2361.
davep added a commit to davep/textual that referenced this issue Apr 24, 2023
@davep
Update tests to handle scroll changes to Container
b896e9d 
See Textualize#2361.
@davep davep mentioned this issue Apr 24, 2023
Merged
@davep davep linked a pull request Apr 24, 2023 that will close this issue
Have Container *not* show scrollbars by default #2365
Merged
@github-actions
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davep davep

Labels
enhancement New feature or request Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Have Container *not* show scrollbars by default davep/textual
2 participants
@davep @willmcgugan