Windows duplicates Escape key input.

[kupuguy]

Have you checked closed issues? https://github.com/Textualize/textual/issues?q=is%3Aissue+is%3Aclosed

Please give a brief but clear explanation of the issue. If you can, include a complete working example that demonstrates the bug. Check it can run without modifications.

It will be helpful if you run the following command and paste the results:

textual diagnose

Feel free to add screenshots and / or videos. These can be very helpful!

To reproduce run textual keys and press some keys. Pressing Esc shows two keys, other keys show only once:

I think the problem is with https://github.com/Textualize/textual/blob/0ad03f3731ae922d1faa6852e14ea60e6932b198/src/textual/drivers/win32.py#L267C64-L267C64

This line processes both the key down and the key up events for esc which results in it appearing as two keys in the input. Simply changing the line to read if key_event.bKeyDown: appears to fix the issue as escape now only appears once in the input and other keys such as function keys continue to work as before.

Textual Diagnostics

Versions

Name	Value
Textual	0.47.1
Rich	13.7.0

Python

| Name | Value
|
|----------------|---------------------------------------------------------------------------------------------------------|
| Version | 3.12.1
|
| Implementation | CPython
|
| Compiler | MSC v.1937 64 bit (AMD64)
|
| Executable | C:\Users\dunca\AppData\Local\pypoetry\Cache\virtualenvs\dwarf-copier-_FteSHy5-py3.12\Scripts\python.exe |

Operating System

Name	Value
System	Windows
Release	11
Version	10.0.22621

Terminal

Name	Value
Terminal Application	Windows Terminal
TERM	Not set
COLORTERM	Not set
FORCE_COLOR	Not set
NO_COLOR	Not set

Rich Console options

Name	Value
size	width=116, height=30
legacy_windows	False
min_width	1
max_width	116
is_terminal	True
encoding	utf-8
max_height	30
justify	None
overflow	None
no_wrap	False
highlight	None
markup	None
height	None

[rodrigogiraoserrao]

Hey, thanks for opening this issue and for doing some investigation beforehand.
We'll add this to our backlog!

[willmcgugan]

In To Do. Suspect @kupuguy is correct about the root cause.

[github-actions]

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

[davep]

Thanks for that @kupuguy, now in main.