Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get_child_by_id and get_widget_by_id #1146

Merged
merged 19 commits into from
Nov 16, 2022
Merged

Add get_child_by_id and get_widget_by_id #1146

merged 19 commits into from
Nov 16, 2022

Commits on Nov 9, 2022

  1. Add get_child_by_id and get_widget_by_id

    @darrenburns
    darrenburns committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    77400b1 View commit details
    Browse the repository at this point in the history

  2. Remove redundant code

    @darrenburns
    darrenburns committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    9334cd2 View commit details
    Browse the repository at this point in the history

  3. Add unit tests for app-level get_child_by_id and get_widget_by_id

    @darrenburns
    darrenburns committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    a49fbac View commit details
    Browse the repository at this point in the history

  4. Remove redundant test fixture injection

    @darrenburns
    darrenburns committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    8f4752c View commit details
    Browse the repository at this point in the history

  5. Update CHANGELOG

    @darrenburns
    darrenburns committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    65da93b View commit details
    Browse the repository at this point in the history

  6. Enforce uniqueness of ID amongst widget children

    @darrenburns
    darrenburns committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    ccce2d9 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into get-widget-by-id

    @darrenburns
    darrenburns authored Nov 9, 2022
    Configuration menu
    Copy the full SHA
    894efc3 View commit details
    Browse the repository at this point in the history

  8. Enforce unique widget IDs amongst widgets mounted together

    @darrenburns
    darrenburns committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    53853bb View commit details
    Browse the repository at this point in the history

  9. Merge branch 'get-widget-by-id' of github.com:Textualize/textual into… 

    … get-widget-by-id
    @darrenburns
    darrenburns committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    ec26ea7 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into get-widget-by-id

    @darrenburns
    darrenburns authored Nov 9, 2022
    Configuration menu
    Copy the full SHA
    00870c7 View commit details
    Browse the repository at this point in the history

  11. Update CHANGELOG.md

    @darrenburns
    darrenburns authored Nov 9, 2022
    Configuration menu
    Copy the full SHA
    4f53c8b View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. Ensuring unique IDs in a more logical place

    @darrenburns
    darrenburns committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    e3ef63d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'get-widget-by-id' of github.com:Textualize/textual into… 

    … get-widget-by-id
    @darrenburns
    darrenburns committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    ebc3a0f View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Merge branch 'main' of github.com:Textualize/textual into get-widget-… 

    …by-id
    @darrenburns
    darrenburns committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    32167eb View commit details
    Browse the repository at this point in the history

  2. Add docstring to NodeList._get_by_id

    @darrenburns
    darrenburns committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    ead198d View commit details
    Browse the repository at this point in the history

  3. Dont use duplicate IDs in tests, dont mount 2000 widgets

    @darrenburns
    darrenburns committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    839c3ec View commit details
    Browse the repository at this point in the history

  4. Mounting less widgets in a unit test

    @darrenburns
    darrenburns committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    755ba94 View commit details
    Browse the repository at this point in the history

  5. Reword error message

    @darrenburns
    darrenburns committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    9cc3fa1 View commit details
    Browse the repository at this point in the history

  6. Use lower-level depth first search in get_widget_by_id to break out e… 

    …arly
    @darrenburns
    darrenburns committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    a85c2b7 View commit details
    Browse the repository at this point in the history