Correct the dimension relative units in grid-rows/columns were assigned to #1640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1406, both the original issue and the other bug that surfaced while investigating it.
grid-rows
/grid-columns
would always be relative to width because theScalarListProperty
wasn't aware of itspercent_unit
.grid-rows
/grid-columns
from CSS files would always be relative to height because the methodStylesBuilder._process_grid_rows_or_columns
had an if statement that always evaluated toFalse
and always pickedUnit.HEIGHT
.