Correct the dimension relative units in grid-rows/columns were assigned to #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this information, grid-rows and grid-columns will have the same percent_unit for scalars that are relative and thus relative dimensions will be wrong.
willmcgugan
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1406, both the original issue and the other bug that surfaced while investigating it.
grid-rows/grid-columnswould always be relative to width because theScalarListPropertywasn't aware of itspercent_unit.grid-rows/grid-columnsfrom CSS files would always be relative to height because the methodStylesBuilder._process_grid_rows_or_columnshad an if statement that always evaluated toFalseand always pickedUnit.HEIGHT.