Enhance Tree so that there is a expand/collapse action that is separate from select
#1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See Textualize#1433. The idea here is that the user has an option of expanding/collapsing a non-leaf node without causing a selected event, or (with auto_expand turned off) cause a selected event without an expand/collapse event. As this will need a new binding, I've chosen the space bar as the key to toggle the expanded state.
I want to add docstrings to the actions I'm adding as part of Textualize#1700, so with this in mind I'm going to add docstrings to all the actions.
davep
changed the title
Tree so that there is a expand/collapse action that is separate from selectTree so that there is a expand/collapse action that is separate from select
willmcgugan
approved these changes
Jan 31, 2023
rodrigogiraoserrao
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1433. The idea here is that the user has an option of expanding/collapsing a non-leaf node without causing a selected event, or (with
auto_expandturned off) cause a selected event without an expand/collapse event.As this will need a new binding, I've chosen the space bar as the key to toggle the expanded state.
In passing I've also added docstrings to all
action_methods -- I feel this is important; helping to make actions (and perhaps bindings in the longer-run) self-documenting.