Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --port option to textual console. #2258

Merged
merged 9 commits into from
Apr 13, 2023
Merged

Add --port option to textual console. #2258

merged 9 commits into from
Apr 13, 2023

Conversation

rodrigogiraoserrao
Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao commented Apr 11, 2023 •
edited
Loading

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

This will close #2014

@rodrigogiraoserrao rodrigogiraoserrao self-assigned this Apr 11, 2023
@rodrigogiraoserrao rodrigogiraoserrao mentioned this pull request Apr 11, 2023
Closed
willmcgugan
willmcgugan requested changes Apr 12, 2023
View reviewed changes
src/textual/app.py Outdated Show resolved Hide resolved
src/textual/cli/cli.py Show resolved Hide resolved
src/textual/devtools/client.py Outdated Show resolved Hide resolved
@rodrigogiraoserrao
Mark unpredictable test as xfail.
d175688 
This test gets an xfail mark until #2254 is open.
willmcgugan
willmcgugan requested changes Apr 13, 2023
View reviewed changes
src/textual/constants.py Outdated Show resolved Hide resolved
willmcgugan
willmcgugan requested changes Apr 13, 2023
View reviewed changes
src/textual/constants.py Outdated Show resolved Hide resolved
src/textual/constants.py Outdated Show resolved Hide resolved
@willmcgugan willmcgugan merged commit bb2c31b into main Apr 13, 2023
@willmcgugan willmcgugan deleted the textual-console-port branch April 13, 2023 10:57
@rodrigogiraoserrao rodrigogiraoserrao mentioned this pull request Apr 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

Assignees

@rodrigogiraoserrao rodrigogiraoserrao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow command-line option to change development port
2 participants
@rodrigogiraoserrao @willmcgugan