Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating styles on demand instead of on_idle #2304

Merged
merged 7 commits into from
Apr 18, 2023
Merged

Updating styles on demand instead of on_idle #2304

merged 7 commits into from
Apr 18, 2023

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Apr 17, 2023 •
edited
Loading

The update_styles call was being done in on_idle.

This meant that when you hover over a widget, the :hover pseudoclass was not immediately applied.

As a result, there was a short window where calls to get_component_styles would return incorrect values.

We close this window by ensuring update_styles is called immediately rather than on_idle.

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@darrenburns darrenburns marked this pull request as ready for review April 18, 2023 09:59
rodrigogiraoserrao
rodrigogiraoserrao approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 🚀

@willmcgugan willmcgugan merged commit 496f8b4 into main Apr 18, 2023
@willmcgugan willmcgugan deleted the update-styles-on-demand branch April 18, 2023 10:36
@darrenburns darrenburns mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

@rodrigogiraoserrao rodrigogiraoserrao rodrigogiraoserrao approved these changes

@davep davep Awaiting requested review from davep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darrenburns @willmcgugan @rodrigogiraoserrao