Updating styles on demand instead of on_idle #2304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
update_styles
call was being done inon_idle
.This meant that when you hover over a widget, the
:hover
pseudoclass was not immediately applied.As a result, there was a short window where calls to
get_component_styles
would return incorrect values.We close this window by ensuring
update_styles
is called immediately rather thanon_idle
.Please review the following checklist.