Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make scrollable containers focusable. #2317

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Make scrollable containers focusable. #2317

merged 2 commits into from
Apr 18, 2023

Conversation

rodrigogiraoserrao
Copy link
Contributor

This will close #2270.

@rodrigogiraoserrao
Copy link
Contributor Author

The example apps didn't break.

willmcgugan
willmcgugan approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@rodrigogiraoserrao rodrigogiraoserrao merged commit 3a7cf08 into main Apr 18, 2023
@rodrigogiraoserrao rodrigogiraoserrao deleted the scrolling-containers-focusable branch April 18, 2023 10:44
This was referenced Oct 31, 2023
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

@davep davep Awaiting requested review from davep

@darrenburns darrenburns Awaiting requested review from darrenburns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scrolling containers should be focusable by default
2 participants
@rodrigogiraoserrao @willmcgugan