Input completion suggestions

[rodrigogiraoserrao]

Adds suggested completions to the Input

• Input accepts a parameter suggestions with a list of suggestions that are shown while the user types.
• Input.suggestions reactive can be used to change the possible suggestions for a given input.
• Input has new component class input--suggestion.
• Keybinding right in Input is also used to accept a suggestion if the cursor is at the end of the input.

Closes #2330.

[willmcgugan]

Video please!

[willmcgugan]

Think we need to go over this one. Chat about it today?

[rodrigogiraoserrao]

Think we need to go over this one. Chat about it today?

Ping me when you're available.

[rodrigogiraoserrao]

Thanks for your guidance @willmcgugan.
This is ready for a second review.
I haven't written any docs yet. Should I add something to the Input reference, for example?

[willmcgugan]

Looking good so far! Will do a review post lunch. Can you add a video?

[rodrigogiraoserrao]

Short video showing the suggestions in action with an artificial sleep of 2s when computing the suggestion to show caching in action:

Screen.Recording.2023-05-23.at.14.47.16.mov

Example app

from textual.app import App, ComposeResult
from textual.suggester import SuggestFromList
from textual.widgets import Input


fruits = ["apple", "pear", "mango", "peach", "strawberry", "blueberry", "banana"]


class FruitsApp(App[None]):
    def compose(self) -> ComposeResult:
        yield Input(suggester=SuggestFromList(fruits))


if __name__ == "__main__":
    app = FruitsApp()
    app.run()

[willmcgugan]

This is great! But we've had a discussion in the office, and I think we need to handle both case sensitive and case insensitive suggestions.

Let's have a chat about it tomorrow.

[willmcgugan]

Should have -> None

[rodrigogiraoserrao]

This is great! But we've had a discussion in the office, and I think we need to handle both case sensitive and case insensitive suggestions.

Sure. A suggester can do that, no problem...
We can chat later.

[rodrigogiraoserrao]

@willmcgugan Case-insensitive logic has been added.

[darrenburns]

I've had a play around with it and it feels good to use :) my only suggestion would be to have case_sensitive=False by default as I think that's more common.

[willmcgugan]

Nice work.