Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the AwaitMount from Markdown.update #2838

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Jun 26, 2023

Markdown.update ultimately mounts some widgets. This PR returns that AwaitMount for the corresponding mount calls, allowing users to (optionally) await to ensure that the mounting of child markdown elements has complete.

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@darrenburns darrenburns marked this pull request as ready for review June 27, 2023 08:31
@darrenburns darrenburns linked an issue Jun 27, 2023 that may be closed by this pull request
@willmcgugan willmcgugan merged commit fbb11dc into main Jun 27, 2023
@willmcgugan willmcgugan deleted the optional-await-markdown-update branch June 27, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional await pattern to Markdown.update
2 participants