Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds an interface for replacing prompt of an individual option in an OptionList #2985

Merged
merged 8 commits into from
Aug 8, 2023
Merged

Adds an interface for replacing prompt of an individual option in an OptionList #2985

merged 8 commits into from
Aug 8, 2023

Commits on Aug 7, 2023

  1. Add ability to replace prompt of an individual option in OptionList

    @nekeal
    nekeal committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    45b6973 View commit details
    Browse the repository at this point in the history

  2. Update the CHANGELOG.md

    @nekeal
    nekeal committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    37bc2e5 View commit details
    Browse the repository at this point in the history

  3. Make use of get_option_at_index instead of directly accessing _options

    @nekeal
    nekeal committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    22926cb View commit details
    Browse the repository at this point in the history

  4. Move error handling for non-existing options to dedicated methods

    @nekeal
    nekeal committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    a3590ac View commit details
    Browse the repository at this point in the history

  5. Minor fixes

    @nekeal
    nekeal committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    d63ac2c View commit details
    Browse the repository at this point in the history

  6. Make use of get_option_index 

    This simplifies error handling in a public interface
    @nekeal
    nekeal committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    913dce7 View commit details
    Browse the repository at this point in the history

  7. Add unit tests for multiline prompts

    @nekeal
    nekeal committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    3ff5b7b View commit details
    Browse the repository at this point in the history

  8. Add snapshot tests for replacing prompt in option list

    @nekeal
    nekeal committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    def2628 View commit details
    Browse the repository at this point in the history