-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataTable sort by function (or other callable) #3090
Merged
darrenburns
merged 13 commits into
Textualize:main
from
joshbduncan:data-table-sort-by-key
Oct 31, 2023
Merged
DataTable sort by function (or other callable) #3090
darrenburns
merged 13 commits into
Textualize:main
from
joshbduncan:data-table-sort-by-key
Oct 31, 2023
Commits on Aug 11, 2023
-
DataTable sort by function (or other callable)
The `DataTable` widget now takes the `by` argument instead of `columns`, allowing the table to also be sorted using a custom function (or other callable). This is a breaking change since it requires all calls to the `sort` method to include an iterable of key(s) (or a singular function/callable). Covers Textualize#2261 using [suggested function signature](Textualize#2512 (comment)) from @darrenburns on PR Textualize#2512.
Configuration menu - View commit details
-
Copy full SHA for fcce7e2 - Browse repository at this point
Copy the full SHA fcce7e2View commit details
Commits on Aug 28, 2023
-
argument change and functionaloty update
Changed back to orinal `columns` argument and added a new `key` argument which takes a function (or other callable). This allows the PR to NOT BE a breaking change.
Configuration menu - View commit details
-
Copy full SHA for 69730d8 - Browse repository at this point
Copy the full SHA 69730d8View commit details
Commits on Aug 29, 2023
-
- Updated the example file for the docs to better show the functionality of the change (especially when using `columns` and `key` together). - Added one new tests to cover a similar situation to the example changes
Configuration menu - View commit details
-
Copy full SHA for 7cd0494 - Browse repository at this point
Copy the full SHA 7cd0494View commit details
Commits on Aug 30, 2023
-
removed unecessary code from example
- the sort by clicked column function was bloat in my opinion
Configuration menu - View commit details
-
Copy full SHA for 312f9ac - Browse repository at this point
Copy the full SHA 312f9acView commit details
Commits on Sep 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5f71d0f - Browse repository at this point
Copy the full SHA 5f71d0fView commit details
Commits on Oct 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a0839cc - Browse repository at this point
Copy the full SHA a0839ccView commit details
Commits on Oct 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ceab271 - Browse repository at this point
Copy the full SHA ceab271View commit details
Commits on Oct 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 948b816 - Browse repository at this point
Copy the full SHA 948b816View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9beb7ed - Browse repository at this point
Copy the full SHA 9beb7edView commit details
Commits on Oct 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6ed8ae3 - Browse repository at this point
Copy the full SHA 6ed8ae3View commit details -
Removing some tests from DataTable.sort as duplicates. Ensure there i…
…s test coverage of the case where a key, but no columns, is passed to DataTable.sort.
Configuration menu - View commit details
-
Copy full SHA for 5db5c1a - Browse repository at this point
Copy the full SHA 5db5c1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d17690 - Browse repository at this point
Copy the full SHA 9d17690View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7541867 - Browse repository at this point
Copy the full SHA 7541867View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.