Modes docs #3233
Merged
Modes docs #3233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmcgugan
commented
Sep 4, 2023
| screen, _ = self._get_screen(_screen()) | ||
| else: | ||
| screen, _ = self._get_screen(self.MODES[mode]) | ||
| new_screen: Screen | str = _screen() if callable(_screen) else _screen |
There was a problem hiding this comment.
Mainly to fix typing.
rodrigogiraoserrao
approved these changes
Sep 4, 2023
docs/guide/screens.md
Outdated
Comment on lines
290
to
292
| You can the switch between these screens at any time by calling [`App.switch_mode`][textual.app.App.switch_mode]. | ||
| When you switch to a new mode, it becomes the active screen stack and the topmost screen in the new stack becomes visible. | ||
| Any calls to [`App.push_screen`][textual.app.App.push_screen] or [`App.pop_screen`][textual.app.App.pop_screen] will affect only the active mode. |
There was a problem hiding this comment.
I feel like this would go well with the paragraph that starts with “In Textual, we can manage this with modes.”.
As it stands, it feels like we're taking too long to tell the reader what are the methods that matter.
Co-authored-by: Rodrigo Girão Serrão <[email protected]>
Co-authored-by: Rodrigo Girão Serrão <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds docs for modes