-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve css error reporting #3582
Merged
Merged
Commits on Oct 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9e5bc82 - Browse repository at this point
Copy the full SHA 9e5bc82View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2918011 - Browse repository at this point
Copy the full SHA 2918011View commit details -
Keep track of what widget/class variable CSS is read from.
We already kept track of the file and widget CSS was read from. Now, we also keep track of the class variable it comes from and we create some structure to transfer that information across the program.
Configuration menu - View commit details
-
Copy full SHA for 9076f41 - Browse repository at this point
Copy the full SHA 9076f41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55fe9d3 - Browse repository at this point
Copy the full SHA 55fe9d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f38ab7 - Browse repository at this point
Copy the full SHA 0f38ab7View commit details
Commits on Oct 25, 2023
-
Drop links in CSS error reporting.
Instead of creating the link explicitly, we let terminal emulators auto-link to the file. This came after a discussion about how/whether we should try to support linking to specific file lines/columns for TCSS files and after some research to see how that would be possible. We decided to drop this feature when we couldn't find information in the standards for 'file://' regarding how to specify line/column numbers and after we found [this iTerm issue](https://gitlab.com/gnachman/iterm2/-/issues/9376) where the creator/maintainer of iTerm says that there is no standard API for opening a file to a particular line number.
Configuration menu - View commit details
-
Copy full SHA for 8b16776 - Browse repository at this point
Copy the full SHA 8b16776View commit details -
Configuration menu - View commit details
-
Copy full SHA for d844982 - Browse repository at this point
Copy the full SHA d844982View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c6eecf - Browse repository at this point
Copy the full SHA 6c6eecfView commit details
Commits on Nov 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for dfddeff - Browse repository at this point
Copy the full SHA dfddeffView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.