Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve css error reporting #3582

Merged
merged 9 commits into from
Nov 1, 2023
Merged

Commits on Oct 24, 2023

  1. Configuration menu
    Copy the full SHA
    9e5bc82 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2918011 View commit details
    Browse the repository at this point in the history
  3. Keep track of what widget/class variable CSS is read from.

    We already kept track of the file and widget CSS was read from. Now, we also keep track of the class variable it comes from and we create some structure to transfer that information across the program.
    rodrigogiraoserrao committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    9076f41 View commit details
    Browse the repository at this point in the history
  4. Fix tests.

    rodrigogiraoserrao committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    55fe9d3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0f38ab7 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Drop links in CSS error reporting.

    Instead of creating the link explicitly, we let terminal emulators auto-link to the file.
    This came after a discussion about how/whether we should try to support linking to specific file lines/columns for TCSS files and after some research to see how that would be possible.
    We decided to drop this feature when we couldn't find information in the standards for 'file://' regarding how to specify line/column numbers and after we found [this iTerm issue](https://gitlab.com/gnachman/iterm2/-/issues/9376) where the creator/maintainer of iTerm says that there is no standard API for opening a file to a particular line number.
    rodrigogiraoserrao committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    8b16776 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d844982 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6c6eecf View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Configuration menu
    Copy the full SHA
    dfddeff View commit details
    Browse the repository at this point in the history