Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notifications CSS. #3583

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix notifications CSS. #3583

merged 1 commit into from
Oct 25, 2023

Conversation

rodrigogiraoserrao
Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao commented Oct 25, 2023 •
edited
Loading

This was merged more or less at the same time as 'initial' was added to CSS but the tests weren't ran with that change. Related PRs: #3566, #3531.

This fix was prompted by CI failures in #3582.

@rodrigogiraoserrao
Fix notifications CSS.
87274cb 
This was merged more or less at the same time as 'initial' was added to CSS but the tests weren't ran with that change.
Related PRs: #3566, #3531.
@rodrigogiraoserrao rodrigogiraoserrao self-assigned this Oct 25, 2023
@rodrigogiraoserrao rodrigogiraoserrao added the bug Something isn't working label Oct 25, 2023
darrenburns
darrenburns approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@darrenburns darrenburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (although not sure the changelog is required since it's a fix for something that wasn't a problem in the prior version)

@rodrigogiraoserrao rodrigogiraoserrao merged commit 9e71173 into main Oct 25, 2023
23 checks passed
@rodrigogiraoserrao rodrigogiraoserrao deleted the fix-notifications branch October 25, 2023 10:00
@TomJGooding
Copy link
Contributor

Thanks @rodrigogiraoserrao, I had just spotted this too but looks like you beat me to fixing it!

@willmcgugan
Copy link
Collaborator

@rodrigogiraoserrao I concur with Darren re changelog. Could you remove that please?

rodrigogiraoserrao added a commit that referenced this pull request Oct 25, 2023
@rodrigogiraoserrao
Remove changelog entry.
12f9e45 
See #3583 (comment).
@rodrigogiraoserrao rodrigogiraoserrao mentioned this pull request Oct 25, 2023
Merged
@rodrigogiraoserrao
Copy link
Contributor Author

I see what you mean about the previous version.
See #3584.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

@darrenburns darrenburns darrenburns approved these changes

@davep davep Awaiting requested review from davep

Assignees

@rodrigogiraoserrao rodrigogiraoserrao

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rodrigogiraoserrao @TomJGooding @willmcgugan @darrenburns