Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blur #3645

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Blur #3645

merged 5 commits into from
Nov 7, 2023

Conversation

willmcgugan
Copy link
Collaborator

Adds :blur pseudo class

Fixes #3439

@willmcgugan willmcgugan requested review from davep, rodrigogiraoserrao and darrenburns and removed request for davep November 7, 2023 15:14
@willmcgugan willmcgugan mentioned this pull request Nov 7, 2023
Closed
darrenburns
darrenburns reviewed Nov 7, 2023
View reviewed changes
Copy link
Member

@darrenburns darrenburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should have a simple pilot test which checks that when something is focused it does not have the blur pseudoclass, and when the focus is removed it gains the blur pseudoclass. The existing tests don't seem to cover this.

@willmcgugan
Copy link
Collaborator Author

@darrenburns Added test

@willmcgugan willmcgugan merged commit c667c86 into main Nov 7, 2023
17 checks passed
@willmcgugan willmcgugan deleted the blur branch November 7, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davep davep davep approved these changes

@darrenburns darrenburns darrenburns approved these changes

@rodrigogiraoserrao rodrigogiraoserrao Awaiting requested review from rodrigogiraoserrao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

blur is listed as a valid pseudo class but doesn't seem to do anything
3 participants
@willmcgugan @davep @darrenburns