Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Select.from_values class method for initializing with iterator #3743

Merged
merged 29 commits into from
Dec 5, 2023
Merged

Add Select.from_values class method for initializing with iterator #3743

merged 29 commits into from
Dec 5, 2023

Commits on Nov 21, 2023

  1. prototype to use class method to initialize Select object using an it… 

    …erator
    @azinneck0485
    azinneck0485 committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    8f7fdb0 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. add docstring and optional arguments to Select.from_values()

    @azinneck0485
    azinneck0485 committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    5793ef1 View commit details
    Browse the repository at this point in the history

  2. add test widget for Select.from_values() and update documentation to … 

    …include an example for its use
    @azinneck0485
    azinneck0485 committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    450553f View commit details
    Browse the repository at this point in the history

  3. add snapshot tests to Select.from_values() class method and update sn… 

    …apshots to include results
    @azinneck0485
    azinneck0485 committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    bafaf97 View commit details
    Browse the repository at this point in the history

  4. update changelog

    @azinneck0485
    azinneck0485 committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    4fe0ecf View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2023

  1. changes to Select.from_value doc and variables names per PR review co… 

    …mments
    @azinneck0485
    azinneck0485 committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    c9cb679 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into Issue3691_AltSelect… 

    …Init

# Conflicts:
#	src/textual/widgets/_select.py
#	tests/snapshot_tests/__snapshots__/test_snapshots.ambr
#	tests/snapshot_tests/test_snapshots.py
    @azinneck0485
    azinneck0485 committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    029d96f View commit details
    Browse the repository at this point in the history

  3. fix merge mistakes

    @azinneck0485
    azinneck0485 committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    fc874aa View commit details
    Browse the repository at this point in the history

  4. fix more merge mistakes

    @azinneck0485
    azinneck0485 committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    5cccc2d View commit details
    Browse the repository at this point in the history

  5. fix more merge mistakes (typos)

    @azinneck0485
    azinneck0485 committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    2a403c3 View commit details
    Browse the repository at this point in the history

  6. change Select.from_value() input parameters to match changes made fro… 

    …m merge
    @azinneck0485
    azinneck0485 committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    7d869bd View commit details
    Browse the repository at this point in the history

  7. re-update snapshots for Select.from_values()

    @azinneck0485
    azinneck0485 committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    e6264b1 View commit details
    Browse the repository at this point in the history

  8. add new tests for Select.from() based on related tests added by merge

    @azinneck0485
    azinneck0485 committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    c14aa59 View commit details
    Browse the repository at this point in the history

  9. update changelog

    @azinneck0485
    azinneck0485 committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    0ee6aff View commit details
    Browse the repository at this point in the history

  10. update another snapshot

    @azinneck0485
    azinneck0485 committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    5c0ea97 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. update Select documentation per code review

    @azinneck0485
    azinneck0485 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    2a6db4b View commit details
    Browse the repository at this point in the history

  2. update doc string and variable names in _select.py per code review

    @azinneck0485
    azinneck0485 committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    23bb964 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Merge branch 'main' into Issue3691_AltSelectInit

    @rodrigogiraoserrao
    rodrigogiraoserrao committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    d305aec View commit details
    Browse the repository at this point in the history

  2. Fix docstrings.

    @rodrigogiraoserrao
    rodrigogiraoserrao committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    ed3f106 View commit details
    Browse the repository at this point in the history

  3. add return type hint for from_values class method

    @azinneck0485
    azinneck0485 committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    ae1a43a View commit details
    Browse the repository at this point in the history

  4. remove unneeded snapshot tests for Select.from_values and update snap… 

    …shot file accordingly
    @azinneck0485
    azinneck0485 committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    6516920 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/Issue3691_AltSelectInit' into Is… 

    …sue3691_AltSelectInit

# Conflicts:
#	src/textual/widgets/_select.py
#	tests/snapshot_tests/__snapshots__/test_snapshots.ambr
    @azinneck0485
    azinneck0485 committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    903920d View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. update snapshots again after merge

    @azinneck0485
    azinneck0485 committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    91efd51 View commit details
    Browse the repository at this point in the history

  2. change type hint for Select.from_values based on review comments

    @azinneck0485
    azinneck0485 committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    4a21734 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. docstring and type hint changes to Select.from_values per code review… 

    … suggestions
    @azinneck0485
    azinneck0485 committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    3c484a8 View commit details
    Browse the repository at this point in the history

  2. Add period.

    @rodrigogiraoserrao
    rodrigogiraoserrao committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    b9f063b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into Issue3691_AltSelectInit

    @rodrigogiraoserrao
    rodrigogiraoserrao committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    986f14e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into Issue3691_AltSelectInit

    @rodrigogiraoserrao
    rodrigogiraoserrao committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    81727f9 View commit details
    Browse the repository at this point in the history

  5. Update snapshot.

    @rodrigogiraoserrao
    rodrigogiraoserrao committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    5a75777 View commit details
    Browse the repository at this point in the history