-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for env variable TEXTUAL_ANIMATIONS #4062
Merged
Merged
Commits on Jan 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d1d6fe2 - Browse repository at this point
Copy the full SHA d1d6fe2View commit details -
Restrict when animations happen.
Go over 'all' (as far as I can tell) animations in Textual. Most of them should only run when the env variable TEXTUAL_ANIMATIONS is set to FULL. A few animations may run on the level BASIC, which are animations that don't delay content appearing: - indeterminate progress bars - loading indicators - button presses - tab underlines - switch toggles - all (?) types of scrolling. These animations are completely disabled when the env var is NONE. The indeterminate progress bar displays a full, static bar and the loading indicator displays a string 'Loading...'. Many animation-related methods also grew a keyword parameter 'animate_on_level' that establishes the minimum level for said animation to take place.
Configuration menu - View commit details
-
Copy full SHA for 136da2f - Browse repository at this point
Copy the full SHA 136da2fView commit details
Commits on Jan 25, 2024
-
Use 'SHOW_ANIMATIONS' from original namespace.
By using 'constants.SHOW_ANIMATIONS' instead of importing the constant directly we make it easier to patch for testing. See: https://mathspp.com/blog/til/patching-module-globals-with-pytest
Configuration menu - View commit details
-
Copy full SHA for fda29ea - Browse repository at this point
Copy the full SHA fda29eaView commit details -
The original issue (#3992) asked for a property on 'App' that allows controlling whether that app's animations should be played or not.
Configuration menu - View commit details
-
Copy full SHA for 37e7668 - Browse repository at this point
Copy the full SHA 37e7668View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98d4fd2 - Browse repository at this point
Copy the full SHA 98d4fd2View commit details -
Add tests for 'basic' animations.
Check that animations that should happen on the BASIC level do happen at that level and don't happen on the NONE level.
Configuration menu - View commit details
-
Copy full SHA for ef55ab3 - Browse repository at this point
Copy the full SHA ef55ab3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 023bb33 - Browse repository at this point
Copy the full SHA 023bb33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89844e8 - Browse repository at this point
Copy the full SHA 89844e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for add06b6 - Browse repository at this point
Copy the full SHA add06b6View commit details
Commits on Jan 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 66f3ec6 - Browse repository at this point
Copy the full SHA 66f3ec6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13c1815 - Browse repository at this point
Copy the full SHA 13c1815View commit details
Commits on Feb 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 15b2063 - Browse repository at this point
Copy the full SHA 15b2063View commit details -
Configuration menu - View commit details
-
Copy full SHA for 264a985 - Browse repository at this point
Copy the full SHA 264a985View commit details -
Configuration menu - View commit details
-
Copy full SHA for 350d53b - Browse repository at this point
Copy the full SHA 350d53bView commit details
Commits on Feb 8, 2024
-
Move AnimationLevel to _types.
See review comment: #4062 (comment).
Configuration menu - View commit details
-
Copy full SHA for 14f83e5 - Browse repository at this point
Copy the full SHA 14f83e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b1e166 - Browse repository at this point
Copy the full SHA 6b1e166View commit details
Commits on Feb 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5cb2471 - Browse repository at this point
Copy the full SHA 5cb2471View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.