Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CSS watcher crashing when file becomes unavailable... #4079

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Fix CSS watcher crashing when file becomes unavailable... #4079

merged 5 commits into from
Jan 31, 2024

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Jan 30, 2024 •
edited
Loading

... and ensure it still works when the file comes back.

Fixes #3996.

@darrenburns darrenburns mentioned this pull request Jan 30, 2024
Closed
@darrenburns darrenburns marked this pull request as ready for review January 30, 2024 15:20
rodrigogiraoserrao
rodrigogiraoserrao approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐍 🚀

willmcgugan
willmcgugan approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a wee request.

src/textual/app.py Outdated Show resolved Hide resolved
@darrenburns darrenburns merged commit 60e0d8d into main Jan 31, 2024
20 checks passed
@darrenburns darrenburns deleted the fix-vim-css-watcher-crash branch January 31, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmcgugan willmcgugan willmcgugan approved these changes

@rodrigogiraoserrao rodrigogiraoserrao rodrigogiraoserrao approved these changes

@davep davep Awaiting requested review from davep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Editing CSS with e.g. vim can crash an app
3 participants
@darrenburns @willmcgugan @rodrigogiraoserrao