Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text area undo redo #4124

Merged
merged 49 commits into from
Feb 14, 2024
Merged

Text area undo redo #4124

merged 49 commits into from
Feb 14, 2024

Commits on Feb 1, 2024

  1. Initial undo related machinery added to TextArea

    @darrenburns
    darrenburns committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    4b87dd9 View commit details
    Browse the repository at this point in the history

  2. Initial undo implementation

    @darrenburns
    darrenburns committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    d548b8d View commit details
    Browse the repository at this point in the history

  3. Basic undo and redo

    @darrenburns
    darrenburns committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    4513b15 View commit details
    Browse the repository at this point in the history

  4. Some more fleshing out of undo and redo

    @darrenburns
    darrenburns committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    e31e49f View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Skeleton code for managing TextArea history

    @darrenburns
    darrenburns committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    98bb0e4 View commit details
    Browse the repository at this point in the history

  2. Initial implementation of undo & redo checkpointing in TextArea

    @darrenburns
    darrenburns committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    a9698ab View commit details
    Browse the repository at this point in the history

  3. Increase checkpoint characters

    @darrenburns
    darrenburns committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    4d02523 View commit details
    Browse the repository at this point in the history

  4. Restoring the selection in the TextArea and then restoring it on undo

    @darrenburns
    darrenburns committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    8c66e44 View commit details
    Browse the repository at this point in the history

  5. Adding docstrings to undo_batch and redo_batch in the TextArea

    @darrenburns
    darrenburns committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    9c7d99b View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Batching edits of the same type

    @darrenburns
    darrenburns committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    c25f215 View commit details
    Browse the repository at this point in the history

  2. Batching edits of the same type

    @darrenburns
    darrenburns committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    7d4344d View commit details
    Browse the repository at this point in the history

  3. Keeping edits containing newlines in their own batch

    @darrenburns
    darrenburns committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    2512f28 View commit details
    Browse the repository at this point in the history

  4. Checking for newline characters in insertion or replacement during un… 

    …do checkpoint creation. Updating docstrings in history.py
    @darrenburns
    darrenburns committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    89c5143 View commit details
    Browse the repository at this point in the history

  5. Fix mypy warning

    @darrenburns
    darrenburns committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    630f479 View commit details
    Browse the repository at this point in the history

  6. Performance improvement

    @darrenburns
    darrenburns committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    4f7eb06 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' of github.com:Textualize/textual into text-area-u… 

    …ndo-redo
    @darrenburns
    darrenburns committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    03425dc View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Merge branch 'main' of github.com:Textualize/textual into text-area-u… 

    …ndo-redo
    @darrenburns
    darrenburns committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    fecfa67 View commit details
    Browse the repository at this point in the history

  2. Add history checkpoint on cursor movement

    @darrenburns
    darrenburns committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    340497a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into text-area-undo-redo

    @darrenburns
    darrenburns authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    2c22aa7 View commit details
    Browse the repository at this point in the history

  4. Fixing merge conflict in Edit class

    @darrenburns
    darrenburns committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    33a4d34 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of github.com:Textualize/textual into text-area-u… 

    …ndo-redo
    @darrenburns
    darrenburns committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    eb60809 View commit details
    Browse the repository at this point in the history

  6. Fixing error in merge conflict resolution

    @darrenburns
    darrenburns committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    be4dc7b View commit details
    Browse the repository at this point in the history

  7. Remove unused test file

    @darrenburns
    darrenburns committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    5577596 View commit details
    Browse the repository at this point in the history

  8. Remove unused test file

    @darrenburns
    darrenburns committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    1fe16be View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Initial testing of undo and redo

    @darrenburns
    darrenburns committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    b74e8f9 View commit details
    Browse the repository at this point in the history

  2. Testing for undo redo

    @darrenburns
    darrenburns committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    31255b5 View commit details
    Browse the repository at this point in the history

  3. Updating lockfile

    @darrenburns
    darrenburns committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    d35bbbc View commit details
    Browse the repository at this point in the history

  4. Add an extra test

    @darrenburns
    darrenburns committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    da20744 View commit details
    Browse the repository at this point in the history

  5. Fix: setting the text property programmatically should invalidate t… 

    …he edit history
    @darrenburns
    darrenburns committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    c4fe944 View commit details
    Browse the repository at this point in the history

  6. Improving docstrings

    @darrenburns
    darrenburns committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    a9e0cd5 View commit details
    Browse the repository at this point in the history

  7. Rename EditHistory.reset() to EditHistory.clear()

    @darrenburns
    darrenburns committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    12292cd View commit details
    Browse the repository at this point in the history

  8. Add docstring to an exception

    @darrenburns
    darrenburns committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    9dc83e8 View commit details
    Browse the repository at this point in the history

  9. Add a pause after focus/blur in a test

    @darrenburns
    darrenburns committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    2665ccd View commit details
    Browse the repository at this point in the history

  10. Forcing CI colour

    @darrenburns
    darrenburns committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    7ef311b View commit details
    Browse the repository at this point in the history

  11. Update focus checkpoint test

    @darrenburns
    darrenburns committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    6849493 View commit details
    Browse the repository at this point in the history

  12. Try to force color in pytest by setting --color=yes in PYTEST_ADDOPTS… 

    … in env var on Github Actions
    @darrenburns
    darrenburns committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    0037a19 View commit details
    Browse the repository at this point in the history

  13. Add extra assertion in a test

    @darrenburns
    darrenburns committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    a4591a7 View commit details
    Browse the repository at this point in the history

  14. Toggle text_area has focus to trigger checkpoint in history

    @darrenburns
    darrenburns committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    85d790e View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Apply grammar/wording suggestions from code review 

    Co-authored-by: Rodrigo Girão Serrão <[email protected]>
    @darrenburns @rodrigogiraoserrao
    darrenburns and rodrigogiraoserrao authored Feb 12, 2024
    Configuration menu
    Copy the full SHA
    566580c View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Making max checkpoints configurable in TextArea history

    @darrenburns
    darrenburns committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    dec7508 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'text-area-undo-redo' of github.com:Textualize/textual i… 

    …nto text-area-undo-redo
    @darrenburns
    darrenburns committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    af7812c View commit details
    Browse the repository at this point in the history

  3. Improve a docstring

    @darrenburns
    darrenburns committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    2a19d4a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of github.com:Textualize/textual into text-area-u… 

    …ndo-redo
    @darrenburns
    darrenburns committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    bc51c8d View commit details
    Browse the repository at this point in the history

  5. Update changelog

    @darrenburns
    darrenburns committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    e5019a9 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Spelling fixes

    @darrenburns
    darrenburns committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    cba27e2 View commit details
    Browse the repository at this point in the history

  2. More spelling fixes

    @darrenburns
    darrenburns committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    c28edfe View commit details
    Browse the repository at this point in the history

  3. Americanize spelling of tab_behaviour (->tab_behavior)

    @darrenburns
    darrenburns committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    76b3233 View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG regarding tab_behaviour->tab_behavior

    @darrenburns
    darrenburns committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    67a3c5c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into text-area-undo-redo

    @darrenburns
    darrenburns authored Feb 14, 2024
    Configuration menu
    Copy the full SHA
    4c43bf3 View commit details
    Browse the repository at this point in the history