check parent focus #4236
Merged
check parent focus #4236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigogiraoserrao
approved these changes
Feb 28, 2024
Comment on lines
+329
to
+330
| if isinstance(node, Widget) and node.focusable: | ||
| return node |
There was a problem hiding this comment.
Do we need to guard against a pathological case where the node that was clicked isn't focusable, one of its DOM ancestors is focusable, but the position clicked doesn't fall within said ancestor?
There was a problem hiding this comment.
That rarely occurs, since widgets are clipped within the boundary of their parents. The one exception is the overlay rule, and we decided that if you click on the overlay it should focus the DOM parent, even if it isn't directly under the mouse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking the screen should check for focusable ancestors, rather than just the widget underneath the mouse.