Keys #4631
Merged
Keys #4631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Kitty's keyboard protocol https://sw.kovidgoyal.net/kitty/keyboard-protocol/#modifiers
This should enable a few more keys, and modifier combinations. Also sane escape key detection.
iTerm implements an earlier version of this protocol, but it seems backwards compatible. Kitty and a number of other more modern terminals implement it fully.
Of course, Terminal.app doesn't. Nothing should break, but it does mean that some keys and combinations will be different. Not sure what we can do about that, other than document it. But it would be a shame not to support it if we can.