-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add classvar ESCAPE_TO_MINIMIZE #4951
Conversation
As mentioned, maybe this should be union of true/false/none. The value at App takes precedence. If the value is set (not None) at the Screen level, the the value from the Screen overrides. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just as a general question - is there something about our binding system that means we're preferring to handle this inside on_key
rather than as a binding (or priority binding)? If we're opting to do this, it might suggest we're missing some functionality in the binding system?
It could be done with a binding. But it would place a burden on the dev not to break it, and to do the right thing if they want to bind escape for something else. Maybe we could add something to the binding system to make that a non-issue in the future, but I don't know what that would look like. |
Fixes #4949