-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow ansi color #5000
Merged
Merged
allow ansi color #5000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenburns
requested changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few typos.
Probably worth adding at least a wee admonition (if not more) in the docs about this in the inline section?
Co-authored-by: Darren Burns <[email protected]>
Co-authored-by: Darren Burns <[email protected]>
Co-authored-by: Darren Burns <[email protected]>
darrenburns
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a switch to allow ANSI color.
The rationale in https://textual.textualize.io/FAQ/#why-doesnt-textual-support-ansi-themes still stands. But for inline apps, it can be jarring to go full RGB. This PR adds an option to enable ansi colors, at the expense of any features that rely on color manipulation.
:ansi
pseudo-selector, which matches when ansi colors are enabled.-ansi-color
class, so that ansi colors can be selectively applied.-ansi-scrollbar
class to widgets, to render the scrollbar with ansi colors (if enabled).