Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating descriptions in BINDINGS #5062

Merged
merged 7 commits into from
Sep 30, 2024
Merged

Updating descriptions in BINDINGS #5062

merged 7 commits into from
Sep 30, 2024

Conversation

darrenburns
Copy link
Member

Fixes #5003, ensuring bindings all have descriptions so don't look weird in the help panel.

Also updates the casing of binding descriptions to be consistent - I went with capitalizing only the first word, since that seems most common and is what has been used recently.

willmcgugan
willmcgugan previously approved these changes Sep 29, 2024
Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Think the failed tests are just snapshots.

@willmcgugan willmcgugan dismissed their stale review September 29, 2024 12:14

I jumped the gun

@darrenburns darrenburns marked this pull request as ready for review September 30, 2024 10:09
@willmcgugan willmcgugan merged commit 1e3d018 into main Sep 30, 2024
20 checks passed
@willmcgugan willmcgugan deleted the binding-descriptions branch September 30, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help panel isn't helpful for bindings without descriptions
2 participants