new loading indicator method #5079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's still selectable via CSS though right? |
|
Yeah, you can still style it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the current method of setting a loading indicator, with a newer mechanism that doesn't suffer from the problem that it turns widgets into containers.
This change does mean that you can't query for the loading indicator. I don't think anyone will care. It's more of a problem to accidentally query it. If someone complains, we can add an accessor of some kind.
As an aside, it wasn't too hard to add this mechanism where things can be rendered but aren't in the DOM. We may want to do this for tooltips and notifications.
Fixes #3935