Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile error with GCC10.1 and -Werror from picojson #92

Closed
markus456 opened this issue Jul 24, 2020 · 2 comments · Fixed by #123
Closed

Compile error with GCC10.1 and -Werror from picojson #92

markus456 opened this issue Jul 24, 2020 · 2 comments · Fixed by #123

Comments

@markus456
Copy link 

/jwt-cpp/include/picojson/picojson.h: In member function ‘const T& picojson::value::get() const [with T = double]’:
/jwt-cpp/include/picojson/picojson.h:386:116: error: suggest parentheses around assignment used as truth value [-Werror=parentheses]
  386 |     (type_ == int64_type && (const_cast<value *>(this)->type_ = number_type, const_cast<value *>(this)->u_.number_ = u_.int64_),
      |                                                                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~

OS and compiler:

Fedora release 32 (Thirty Two)
gcc (GCC) 10.1.1 20200507 (Red Hat 10.1.1-1)
markus456 added a commit to mariadb-corporation/MaxScale that referenced this issue Jul 24, 2020
@markus456
Fix jwt-cpp build failure with GCC 10.1
faa61cc 
A patch step is required to fix the code until the maintainer fixes the
problem: Thalhammer/jwt-cpp#92
markus456 added a commit to mariadb-corporation/MaxScale that referenced this issue Jul 24, 2020
@markus456
Fix jwt-cpp build failure with GCC 10.1
130f088 
A patch step is required to fix the code until the maintainer fixes the
problem: Thalhammer/jwt-cpp#92
@prince-chrismc prince-chrismc changed the title Compile error with GCC10.1 and -Werror Compile error with GCC10.1 and -Werror from picojson Jul 24, 2020
@prince-chrismc
Copy link
Collaborator

picojson is not maintained. When next jwt-cpp release comes out you can pick any JSON library your heart desires!

@mohsenomidi
Copy link

picojson is not maintained. When next jwt-cpp release comes out you can pick any JSON library your heart desires!

This will be great 😍

@Thalhammer Thalhammer mentioned this issue Jul 29, 2020
Merged
Thalhammer added a commit that referenced this issue Jan 18, 2021
@Thalhammer
Update picojson to most recent version
7362900 
closes #92
@Thalhammer Thalhammer mentioned this issue Jan 18, 2021
Merged
Thalhammer added a commit that referenced this issue Jan 18, 2021
@Thalhammer
Update picojson to most recent version (#123)
cf11f09 
closes #92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update picojson to most recent version Thalhammer/jwt-cpp
3 participants
@markus456 @prince-chrismc @mohsenomidi