-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NuGet Pkg for v0.6.0 using GitHub Actions #262
Conversation
# Controls when the workflow will run | ||
on: | ||
# Allows you to run this workflow manually from the Actions tab | ||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered using https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release so that it will get pushed automatically?
I do like manual so we can test but less is more 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think manual is fine while we test, we can switch it later once we are more familiar with how it works.
- name: Setup NuGet.exe for use with actions | ||
uses: NuGet/[email protected] | ||
with: | ||
nuget-api-key: ${{ secrets.nuget_api_key }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need access to the Nuget package to make an API token? I made an account with the same user name if you don't mind :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, he needs to add one of us (or ideally both) as a owner for the package and we then need to create a secret here with the push token.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are the only one who can add secrets AFAIK, I dont have access to the settings page where they can be added
(my evil genius plan to steal power is working muahahah 😈 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont have access to the settings page where they can be added
Guess I need to add them myself then 😈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added you both access as owners directly via NuGet.org so you can manage the package even before we publish the next one:
And the next commit will have you both added as owners in the .nuspec file, together with the version updated to a test one so you can experiment with running the workflow with your own token :)
Looks super good just a few questions |
…to test for validatying workflow on Main
@Thalhammer and @prince-chrismc, with the latest commit you should be ready to configure the secret and try running the workflow, it will generate a pre-release package "-dev0.2" that we can do a final validation before publishing the release package. |
@prince-chrismc Can you create a token for nuget ? |
should be in you inbox :) |
This PR is related to discussion #243 and is a 3 file contribution:
Some context on the current approach: