Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added convenience function for no base64 der to pem #283

Merged
merged 2 commits into from
Mar 14, 2023
Merged

added convenience function for no base64 der to pem #283

merged 2 commits into from
Mar 14, 2023

Conversation

dennisyakovlev
Copy link
Contributor

I think a helper function for der to pem cert if original is not base64 encoded would nice.

Thalhammer
Thalhammer reviewed Mar 13, 2023
View reviewed changes
Copy link
Owner

@Thalhammer Thalhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nitpicks, I am fine with it otherwise.

include/jwt-cpp/jwt.h Outdated Show resolved Hide resolved
include/jwt-cpp/jwt.h Outdated Show resolved Hide resolved
@Thalhammer Thalhammer merged commit c2b43e6 into Thalhammer:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thalhammer Thalhammer Thalhammer left review comments

@prince-chrismc prince-chrismc prince-chrismc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dennisyakovlev @Thalhammer @prince-chrismc