Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update OR version and update for API changes #756

Merged
merged 2 commits into from
Dec 13, 2021

Conversation

maliberty
Copy link
Member

Signed-off-by: Matt Liberty [email protected]

@maliberty maliberty marked this pull request as draft December 11, 2021 18:32
@maliberty
Copy link
Member Author

@donn I can't tell exactly what is failing here - there is tons of output. I don't know if these are real or not. Any hints?

@donn
Copy link
Collaborator

donn commented Dec 12, 2021

These are definitely real. What you should typically do is check a failing design's report at the end of each run:

IMG_0127

Sometimes, the failures are because the designs are failing when compared to an earlier benchmark, but most likely failures are just when OpenLane fails outright. In which case, you need to download the logs. You can't download them per-design because that's just how GitHub works, so what you can do is download all of the run_tarballs.zip file from the CI run:

IMG_0128

Inside the tarball for each run, there's a file called flow_summary.log. With the APU as an example, here's the error:

IMG_0126

In this scenario, it appears that there have been some regression in OpenROAD causing designs that were previously working to fail.

When updating OpenROAD, what I typically do is run make fastest_test_set locally first as a sanity check, then see which designs fail, then package tarballs and pass them on to you guys. I can do that tomorrow if you'd like.

@mithro
Copy link

mithro commented Dec 12, 2021 via email

@donn
Copy link
Collaborator

donn commented Dec 13, 2021

Agreed, @mithro. I'll see what I can do there.


APU issue is The-OpenROAD-Project/OpenROAD#1419, isolating the rest...

@donn
Copy link
Collaborator

donn commented Dec 13, 2021

{APU, wbqspiflash, zipdiv, xtea, digital_pll_sky130_fd_sc_hd, usb_cdc_core, usb} are all failing because of OpenROAD#1419

Signed-off-by: Matt Liberty <[email protected]>
@maliberty maliberty marked this pull request as ready for review December 13, 2021 21:16
@maliberty maliberty requested a review from donn December 13, 2021 21:17
Copy link
Collaborator

@donn donn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@donn donn merged commit 412fcf0 into The-OpenROAD-Project:master Dec 13, 2021
@maliberty maliberty deleted the odb-api branch December 13, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants