-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rsz: Add command for eliminating dead logic #6122
Conversation
Signed-off-by: Martin Povišer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
It would be interesting to run this on megaboom. megaboom has a 50% reduction in instances after hierarchical synthesis if the same(?) is done by naja edit. @jeffng-or @maliberty FYI |
I think naja also does constant propagation which could be another item of interest in OR. |
I don't yet see the clang-tidy thumbs up |
Signed-off-by: Martin Povišer <[email protected]>
Signed-off-by: Martin Povišer <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
@maliberty tooling is happy now (expect for CI which seems to fail for an external reason) |
I see OpenSTA does some constant propagation for its own purposes, the result of which is available under Some of the constants originate from tie-low/tie-high cells, but there are also constants sourced from SDC:
Especially |
set_case_analysis is more for modelling a particular operating mode and we wouldn't want to remove logic based on it (it could be used in another mode). Netlist constants should be the basis for logic removal. |
That's what I thought |
Signed-off-by: Martin Povišer <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
It would be good to have at least one unit test. |
Signed-off-by: Martin Povišer <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Martin Povišer <[email protected]>
deb0a76
to
a7704c0
Compare
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
Removes instances which are all:
In ORFS on nangate45/black_parrot, which has hierarchical synthesis enabled, this finds plenty of cells to eliminate.
At floorplan stage, pre-elimination
post-elimination