-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Yosys version on DependencyInstaller.sh #6140
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Augusto Berndt <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
@maliberty The CI is failing for this PR with the following messages:
Looking at both yosys and eqy repositories, in fact we don't have this yosys-0.47 branch. But we also don't have the yosys-0.43, which is the branch name used previously. Do you know how it works? I think we are missing something here... |
@povik please advise |
We dropped the |
Signed-off-by: Augusto Berndt <[email protected]>
clang-tidy review says "All clean, LGTM! 👍" |
Apparently the |
There looks to be a yosys-0.47 tag - https://github.com/YosysHQ/eqy/releases/tag/yosys-0.47 Why does that lead to an error? |
When we use the
When using
It seems that we're trying to clone both eqy and yosys repos using the same version name, which will not work. |
@povik could you put a 0.47 tag on same eqy commit as yosys-0.47? |
You're not the first to ask (YosysHQ/yosys#4586). I will need to get the internal go-ahead which will take a day or two |
It won't happen this week that we get a consistent tag. I would say it's simple enough but it's not up to me. |
@gudeh you can wait or split the tag for now |
I would argue for spliting the tag for now, and in the new yosys update I will go back to it and fix the tag names. |
I was having packages issues with EQY version, it should be the same version as Yosys. The DependencyInstaller.sh was not solving the issue. After manually updating to 0.47 my EQY and Yosys versions matched, as supposed to.