Optimizations #2
Conversation
| @@ -17,97 +18,97 @@ func main() { | |||
| directory := flag.String("directory", "", "the absolute directorypath to search for duplicates") | |||
| flag.Parse() | |||
|
|
|||
| fmt.Println("DupsFindr started with: ", *directory) | |||
| if len(*directory) == 0 { | |||
There was a problem hiding this comment.
Checking the length and then panicking increases readability and reduces indentations.
| wg.Add(1) | ||
| // recieve from files and add to slice | ||
| go readFiles(files, &allFilesWithoutDuplicates, &counter, &wg) | ||
| counter := 0 |
There was a problem hiding this comment.
Is there a reason counter is created but never used in this function?
| // is this okay, or should it be closed after the last directory was read? | ||
| close(files) | ||
| wg.Wait() | ||
| // is this okay, or should it be closed after the last directory was read? |
There was a problem hiding this comment.
It is best practice to call close() only from the sending goroutine, but that won't work here since there are multiple sending goroutines.
| } | ||
|
|
||
| func readDirectory(directory string, files chan<- string, wg *sync.WaitGroup) { | ||
| wg.Add(1) |
There was a problem hiding this comment.
I moved Add() into the function so that a call to readDirectory() can be used without having to call Add() yourself.
| } | ||
|
|
||
| info, err := f.Stat() | ||
| defer f.Close() |
There was a problem hiding this comment.
Defering the call to Close() only if err == nil
| } | ||
|
|
||
| for _, directoryInfo := range directoryInfos { | ||
| path := fmt.Sprintf("%s/%s", directory, directoryInfo.Name()) |
There was a problem hiding this comment.
Introducing a new variable that holds the path since it will be used two times. It is common practice to use fmt.Sprintf instead of classical string concatenation.
| go readDirectory(*directory, files, &wg) | ||
| var wg sync.WaitGroup | ||
| // read the directory and send all files to the channel | ||
| go readDirectory(*directory, files, &wg) |
There was a problem hiding this comment.
Könnte man optimieren auch wenns für den Regelfall wohl nicht relevant ist.
|
Wunderbar! |
This PR contains: