Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KMP Search Algorithm #2821

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add KMP Search Algorithm #2821

wants to merge 11 commits into from

Conversation

dev-priyanshu15
Copy link

@dev-priyanshu15 dev-priyanshu15 commented Oct 12, 2024 •
edited
Loading

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@dev-priyanshu15
Copy link
Author

and dont forget to add hacktoberfest-accepted label please

@dev-priyanshu15
Update and rename Knuth-Morris-Pratt (KMP) Algorithm for Pattern Sear…
7be0b8f 
…ching to KMPAlgorithm.cpp

fix: Update KMP algorithm implementation to follow best practices

- Changed file extension to .cpp for proper C++ recognition.
- Removed usage of non-portable <bits/stdc++.h> header.
- Removed 'using namespace std;' and prefixed standard library components with std::.
- Ensured code portability and compliance with repository standards.
@realstealthninja
Copy link
Collaborator

One file per pull request please.

@dev-priyanshu15
Delete search/Quickselect for Finding the k-th Smallest Element.cpp
5539baf 
for 1 file i had deleted Quickselect for Finding the k-th Smallest Element.cpp will add after my review
@dev-priyanshu15
Delete search/Staircase Search in a 2D Matrix
fd2b962 
deleted as 1 file needed
@dev-priyanshu15
Merge branch 'master' into master
92ed44e
@realstealthninja realstealthninja changed the title Add KMP Search Algorithm and Quickselect for k-th Smallest Element to Searching Section Add KMP Search Algorithm Oct 21, 2024
realstealthninja
realstealthninja requested changes Oct 21, 2024
View reviewed changes
search/KMPAlgorithm.cpp
@@ -0,0 +1,58 @@
#include <iostream>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check https://github.com/TheAlgorithms/C-Plus-Plus/blob/master/CONTRIBUTING.md and document/add tests accordingly

@realstealthninja realstealthninja added awaiting modification Do not merge until modifications are made Proper Documentation Required requested to write the documentation properly labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realstealthninja realstealthninja realstealthninja requested changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
awaiting modification Do not merge until modifications are made Proper Documentation Required requested to write the documentation properly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dev-priyanshu15 @realstealthninja