fix: resolve binary addition and substring issues in Karatsuba algorithm #2851
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: correct binary addition and substring handling in the Karatsuba algorithm
add_strings
function to handle binary addition correctly.safe_substr
function to manage leading zeros and extract substrings properly.1LL <<
for 64-bit integers.This fixes incorrect results from the Karatsuba algorithm for binary multiplication.
Description of Change
Checklist
Notes: