Fix binary addition logic in add_strings function #2862
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This pull request addresses a bug in the
add_strings
function located individe_and_conquer/karatsuba_algorithm_for_fast_multiplication.cpp
. The original implementation incorrectly used bitwise XOR and character casting for binary addition, leading to incorrect results during binary multiplication. The updated code uses proper integer arithmetic to handle binary addition correctly, ensuring accurate summation of binary strings.Fixes #2848 (Incorrect Binary Addition Logic in add_strings).
Checklist
Notes: This fix corrects the binary addition logic, ensuring accurate results for binary multiplication.