Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi language #3

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Multi language #3

wants to merge 6 commits into from

Conversation

opoet7
Copy link

@opoet7 opoet7 commented Jan 23, 2021

No description provided.

@bl-ue
Copy link

bl-ue commented Jan 23, 2021

@opoet7 It looks like js/scripts.js was recovered from a minified version...
For example this code:

exitfromloop = false;
var OS_LIST = [];
var cmdList = [];
var OS_ARRAY_WITH_DATA = {};

was changed to this:

exitfromloop = !1;
var OS_LIST = [],
    cmdList = [],
    OS_ARRAY_WITH_DATA = {};

which looks like typical minified JavaScript code.

Also there are no comments, and many newlines were stripped.

But the HTML looks a lot better...

🤔

index.html Outdated
@@ -67,6 +67,9 @@
Submit
</button>
</form>
<form class="navbar-form navbar-right" role="search">
<select id="language" name="language" class="form-control"></select>
</form>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's mixed whitespace (spaces/tabs) in these lines as well.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me like someone should:

  1. Close this PR
  2. Open a new PR completely normalizing the whitespace in all files
  3. After that is merged, open a new version of this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants