Always set the Content-Length header for requests with a body #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS requires the Content-Length header when the body is sent, otherwise the request signature will not match. Elasticsearch.js does not set a Content-Length header for request bodies of DELETE requests. Since this is a requirement for requests to AWS, the connector should take up that responsibility.
|
I'm not sure that the fix belongs in this module, although it will work as a workaround. |
|
The request is generated by elasticsearch.js and http-aws-es performs the necessary steps to get it ready for AWS. The HTTP request handler of aws-sdk only uses the ready request to send it. Even for AWS Cloudsearch, the Content-Length is set by the module that generates the request(the interface object). |
|
@subodhkhanduri1 Good point. There's definitely some inconsistency in the SDK on when Content-Length is set automatically and when it isn't. I'd be happy with this patch to get things working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS requires the Content-Length header when the body is sent, otherwise the request signature will not match.
Elasticsearch.js does not set a Content-Length header for request bodies of DELETE requests.
Since this is a requirement for requests to AWS, the connector should take up that responsibility.
Fixes #19