Enable proxy use and other httpOptions goodness, Extract aws-sdk configuration from SDK if not provided. #8
Conversation
…is allows the use of proxies and other agent goodness.
|
Assume the user created a standard awsConfig object, It is desired to have a new field 'httpOptions' in the amazonES object to accept whatever options the user had in the awsConfig object: amazonES: { On line 91, the code can be changed to receive the htttpOptions from amazonES object: req = send.handleRequest(request, this.amazonES.httpOptions, function (_incoming) { |
…the request. Make the amazonES configuration parameter optional, allowing for the configuration to be extracted from the existing configuration of aws-sdk.
|
This is a good point. Consuming code should be able to explicitly provide the httpOptions if desired. It is also nice to not have to explicitly provide the configuration at all. See last commit. |
erikerikson
changed the title
|
@erikerikson: I think it might be better to split this PR in two, one for httpOptions and one for aws-sdk configuration. I would be easier to merge I guess. |
|
Thanks for this. I will be making a new release once I have implemented tests for this module. |
connector-es6.js
Outdated
| return AWS.config.credentials; | ||
| } | ||
| } | ||
| getHttpOptions() { |
There was a problem hiding this comment.
Should this function definition have amazonEs passed in as a parameter?
There was a problem hiding this comment.
Erm... Yes. Yes, it should!
Replace null with the httpOptions object that aws-sdk is configured with. As per the sdk, handleRequest requires those be passed in. This allows the use of proxies via agent and other httpOptions goodness.