Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade tough-cookie-file-store from 1.2.0 to 2.0.0 #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheJ-Erk400
Copy link
Owner

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json
    • package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
medium severity 718/1000
Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 6.5
Prototype Pollution
SNYK-JS-TOUGHCOOKIE-5672873
Yes Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: tough-cookie-file-store The new version differs by 17 commits.
  • 94ef872 Merge branch 'release/v2.0.0'
  • 7273ba0 Bump version number. Updated readme and changelog
  • 41cdfa5 Updated changelog
  • 5df7fe0 Added changelog. Added JSDoc
  • 58e51b6 Test improvements
  • b27a42b Code cleaning
  • 27e2e67 Update readme
  • 8cdf0ef Set up Travis CI. Removed node v6 since nyc is not compatible
  • 0e785db Set up Travis CI
  • d38afe7 Update readme and package definition
  • 16dde40 Remove old library reference
  • 77dd565 Clear empty cookies file after test
  • 1907a19 Fix empty cookies file
  • 3217cc9 Added tests
  • 6cb776c Refactored library
  • b9f2228 Updated ignore file. Added configuration files
  • 6f14b28 Merge tag 'v1.2.0' into develop

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Prototype Pollution

@stackblitz
Copy link

stackblitz bot commented Jul 1, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
tough-cookie-file-store 1.2.0...2.0.0 None +5/-0 225 kB ivanmarban

@socket-security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Dynamic require url-parse 1.5.10
Obfuscated require url-parse 1.5.10
Unmaintained url-parse 1.5.10
  • Last Publish: 2/22/2022, 3:49:03 PM
Major refactor tough-cookie-file-store 2.0.0
  • Change Percentage: 105.03
  • Current Line Count: 634
  • Previous Line Count: 241
  • Lines Changed: 919
URL strings tough-cookie-file-store 2.0.0
New author querystringify 2.2.0
Unmaintained querystringify 2.2.0
  • Last Publish: 8/17/2020, 6:18:46 PM
No v1 universalify 0.2.0
Unmaintained universalify 0.2.0
  • Last Publish: 7/25/2020, 1:35:08 PM
Unmaintained requires-port 1.0.0
  • Last Publish: 10/30/2015, 2:42:33 PM
URL strings requires-port 1.0.0

Next steps

What is dynamic require?

Dynamic require can indicate the package is performing dangerous or unsafe dynamic code execution.

Packages should avoid dynamic imports when possible. Audit the use of dynamic require to ensure it is not executing malicious or vulnerable code.

What is obfuscated require?

Package accesses dynamic properties of require and may be obfuscating code execution.

The package should not access dynamic properties of module. Instead use import or require directly.

What are unmaintained packages?

Package has not been updated in more than a year and may be unmaintained. Problems with the package may go unaddressed.

Package should publish periodic maintenance releases if they are maintained, or deprecate if they have no intention in further maintenance.

What is a major refactor?

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Consider waiting before upgrading to see if any issues are discovered, or be prepared to scrutinize any bugs or subtle changes the major refactor may bring. Publishers my consider publishing beta versions of major refactors to limit disruption to parties interested in the new changes.

What are URL strings?

Package contains fragments of external URLs or IP addresses, which may indicate that it covertly exfiltrates data.

Avoid using packages that make connections to the network, since this helps to leak data.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is wrong with semver < v1?

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

If the package sees any general use, it should begin releasing at version 1.0.0 or later to benefit from semver.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants